Add -Wtostring-interpolated to warn if interpolator uses toString#10776
Merged
som-snytt merged 1 commit intoJun 20, 2024
Conversation
6e463fb to
ab4a1d1
Compare
Contributor
Author
|
Previous feedback at wartremover is to allow at least Therefore, no accommodation is made yet here. A future version can take a typeclass, implicit locale, etc. |
ab4a1d1 to
cbf369d
Compare
cbf369d to
dc21f58
Compare
Contributor
Author
|
Added the exclusion for primitives but not Dotty reflect says don't use
|
Contributor
Author
|
spurious error on first commit after rebase then |
lrytz
reviewed
Jun 17, 2024
Member
lrytz
left a comment
There was a problem hiding this comment.
LGTM otherwise! I'm not familiar with the code though.
dc21f58 to
6afc3a5
Compare
Contributor
Author
|
gah |
Contributor
Author
|
/rebuild |
Contributor
Author
|
fool me twice |
lrytz
approved these changes
Jun 18, 2024
Member
lrytz
left a comment
There was a problem hiding this comment.
Nice, thank you! Let's squash before merge.
d138e6c to
1ac2451
Compare
Contributor
Author
|
Squashed & rebased for ✔️ (🤞 ) |
Adds -Wtostring-interpolated to warn if interpolator uses toString
Adds -Wtostring-interpolated to warn if interpolator uses toString-Wtostring-interpolated to warn if interpolator uses toString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
-Wtostring-interpolatedwhich warns if a standard interpolator usestoStringto convert a value which is not string or primitive type.-Wconf:cat=w-flag-tostring-interpolated:eto boost.Also restores edge case
f"${ "hello" }%b"which is"true"for non-boolean arg. That became an error in previous refactor, possibly intentionally. (It is arguably an obscure feature of format.) (Edit: the C.I. error reminds me that the change was to make the expected type Boolean, so that conversions work normally. That is also edge casey. Maybe it can try boolean, null, and any? Edit: yes, try non-any first, then any if allowed.)The "default"
%sis improved so that the warning position is at the interpolated element ins"$x".Follow-up to #8654