Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Align with Scala 3: Support Scala 3.5 in TASTy reader#10811

Merged
SethTisue merged 3 commits into
scala:2.13.xfrom
scalacenter:tasty/upgrade-3.5.0
Jul 18, 2024
Merged

Align with Scala 3: Support Scala 3.5 in TASTy reader#10811
SethTisue merged 3 commits into
scala:2.13.xfrom
scalacenter:tasty/upgrade-3.5.0

Conversation

@bishabosha
Copy link
Copy Markdown
Member

@bishabosha bishabosha commented Jul 15, 2024 •
edited
Loading

restores pipelining tests on windows - (3.4.0 actually fixed the underlying problem with writing to Jars)

scala 3.5.0-RC4 changed the constructor of its ConsoleReporter - so patched that here.

also the experimental definition error message changed again :)

also test compilation of std library with 3.5.0

@bishabosha bishabosha requested a review from SethTisue July 15, 2024 16:16
@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Jul 15, 2024
@SethTisue SethTisue added the prio:hi high priority (used only by core team, only near release time) label Jul 15, 2024
@bishabosha bishabosha force-pushed the tasty/upgrade-3.5.0 branch 2 times, most recently from 7cd02ee to 2fc3e49 Compare July 15, 2024 17:15
@bishabosha
Copy link
Copy Markdown
Member Author

bishabosha commented Jul 15, 2024 •
edited
Loading

Added tracked param and flexible types (i.e. ignore them, but don't crash)

reject when you see the new quote, splice, quote pattern, splice pattern.

Done as far as I see

@bishabosha bishabosha force-pushed the tasty/upgrade-3.5.0 branch from 2fc3e49 to 462bf05 Compare July 15, 2024 17:22
@bishabosha
Copy link
Copy Markdown
Member Author

bishabosha commented Jul 16, 2024 •
edited
Loading

@SethTisue @lrytz the Scala 2.13 library is refusing to build due to a warning about not being allowed to pass implicit arguments explicitly without (using ...) - might need some advice here or another PR needed to prepare

EDIT: for now I set to use the current dotty version for building the library - and latest for testing tasty reader

@bishabosha bishabosha force-pushed the tasty/upgrade-3.5.0 branch from 462bf05 to adf1152 Compare July 16, 2024 16:43
@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Jul 16, 2024 •
edited
Loading

got good news for ya! using is already accepted, even without -Xsource:3 (as per #10075)

@SethTisue SethTisue marked this pull request as draft July 16, 2024 18:45
@SethTisue SethTisue assigned bishabosha and unassigned SethTisue Jul 16, 2024
@bishabosha bishabosha force-pushed the tasty/upgrade-3.5.0 branch from d14ae6e to db596f5 Compare July 17, 2024 13:16
@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Jul 17, 2024 •
edited
Loading

@bishabosha this necessitates releasing 2.13.15 fairly quickly after 3.5.0 final comes out, yes? as per our usual practice?

@bishabosha
Copy link
Copy Markdown
Member Author

bishabosha commented Jul 17, 2024

it should be like usual yeah

@bishabosha bishabosha marked this pull request as ready for review July 17, 2024 20:49
@bishabosha
Copy link
Copy Markdown
Member Author

bishabosha commented Jul 17, 2024

@SethTisue ci looks good

@SethTisue SethTisue added release-notes worth highlighting in next release notes prio:blocker release blocker (used only by core team, only near release time) and removed prio:hi high priority (used only by core team, only near release time) prio:blocker release blocker (used only by core team, only near release time) labels Jul 17, 2024
@SethTisue SethTisue merged commit dd71307 into scala:2.13.x Jul 18, 2024
@bishabosha bishabosha deleted the tasty/upgrade-3.5.0 branch July 18, 2024 22:28
@SethTisue SethTisue changed the title Support Scala 3.5.0-RC4 in TASTy Reader Align with Scala 3: Support Scala 3.5 in TASTy reader Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees

@bishabosha bishabosha

Labels

release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.13.15

Development

Successfully merging this pull request may close these issues.

3 participants

@bishabosha @SethTisue @scala-jenkins