Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make lhs of #::: in LazyList.Deferrer lazier #10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 2.13.x
Choose a base branch
from

Conversation

NthPortal
Copy link
Contributor

@NthPortal NthPortal commented Jul 27, 2024

not forward compatible

  • wait until forward compatibility is disabled (2.13.16?)

@NthPortal NthPortal added the library:collections PRs involving changes to the standard collection library label Jul 27, 2024
@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Jul 27, 2024
"Use the #::: method with a by-name parameter instead; see docs for more info",
since = "2.13.15"
)
def #:::[B >: A]()(prefix: LazyList[B]): LazyList[B] = prefix lazyAppendedAll l()
Copy link
Contributor Author

@NthPortal NthPortal Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a trick I learned from @‍armanbilge (deliberate fake tag, I don't want to ping) to maintain bincompat but also prevent source collision

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can even declare it as protected[immutable] still that it doesn't appear in the public API at all.

@SethTisue SethTisue requested a review from a team July 29, 2024 04:52
@NthPortal
Copy link
Contributor Author

I believe the failure is that they're not forward compatible? but I thought that was supposed to be disabled now?

@SethTisue
Copy link
Member

hello, nice to see you here!

I thought that was supposed to be disabled now?

Not for 2.13.15. Groundwork has been lain for disabling it, perhaps in 2.13.16.

@NthPortal NthPortal removed this from the 2.13.15 milestone Aug 6, 2024
@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Aug 6, 2024
@SethTisue SethTisue modified the milestones: 2.13.15, 2.13.16 Aug 14, 2024
@SethTisue
Copy link
Member

perhaps in 2.13.16.

2.13.16 will be a modest release without bincompat changes, but it appears increasingly likely that we can start accepting this kind of PR for 2.13.17

@SethTisue SethTisue marked this pull request as draft November 6, 2024 18:02
@SethTisue SethTisue modified the milestones: 2.13.16, 2.13.17 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library:collections PRs involving changes to the standard collection library library:not-forward-bincompat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants