Handle AntiPolyType in Symbol.alternatives #10832
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
commented
Aug 12, 2024
| cannot be applied to (Int) | ||
| def f = A.a[Int][String](0) | ||
| ^ | ||
| 1 error |
There was a problem hiding this comment.
Did not attempt to compete with dotty.
8 | def f = A.a[Int][String](0)
| ^^^
| None of the overloaded alternatives of method a in object A with types
| [F](x: String): Int
| [F](x: Int): Int
| match type arguments [Int] and type arguments [String] and arguments ((0 : Int))
|
| where: F is a type variable
26ff2ce to
175256b
Compare
lrytz
reviewed
Aug 14, 2024
| @@ -4162,6 +4161,8 @@ trait Types | |||
| case TypeRef(pre, sym, Nil) => copyTypeRef(tycon, pre, sym, args) | |||
| case TypeRef(pre, sym, bogons) => devWarning(s"Dropping $bogons from $tycon in appliedType.") ; copyTypeRef(tycon, pre, sym, args) | |||
| case PolyType(tparams, restpe) => restpe.instantiateTypeParams(tparams, args) | |||
| case MethodType(params, resultType) => resultType | |||
| case NullaryMethodType(resultType) => resultType | |||
There was a problem hiding this comment.
Does this happen with erroneous trees? Could you add a comment, maybe a devWarning like above?
som-snytt
commented
Nov 5, 2024
| @@ -2936,8 +2936,7 @@ trait Types | |||
|
|
|||
| object MethodType extends MethodTypeExtractor | |||
|
|
|||
| // TODO: rename so it's more appropriate for the type that is for a method without argument lists | |||
| // ("nullary" erroneously implies it has an argument list with zero arguments, it actually has zero argument lists) | |||
| // Nullary not nilary, i.e., parameterlistless not merely parameterless | |||
There was a problem hiding this comment.
ah this is where I fixed the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#10628