Relax PhaseAssembly about loose constraints #10858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phases referenced in constraints (runsAfter, runsBefore) may not exist when running Scaladoc. - Don't warn about constraints on non-existing phases in Scaladoc - Drop invalid constraints (runsAfter / runsRightAfter / runsBefore) - Drop unreachabele phases (no valid runsAfter / runsRightAfter)
|
I don't think a surgeon is allowed to perform heart surgery on their own child, or in this case, in-utero heart surgery, so I will step outside the OR, pull off my mask in a demonstrative manner and throw my scrubs into the bin. Less metaphorically, I have a rib injury from trail running so I didn't sleep for a week, as happens, so I'm out of gas for this issue. |
😱 – rest, feel better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phases referenced in constraints (runsAfter, runsBefore) may not exist when running Scaladoc.
Minimal changes so we can move ahead with 2.13.15. Includes all tests from #10856 but not the code cleanups.
Fixes scala/bug#13028.