PC invalidates previous work on new run #10867
Conversation
| @@ -301,6 +301,7 @@ class Global(settings: Settings, _reporter: Reporter, projectName: String = "") | |||
| def isOutOfDate: Boolean = outOfDate | |||
|
|
|||
| def demandNewCompilerRun() = { | |||
| if (!lastWasReload) allSources.foreach(getUnit(_).foreach(reset(_))) | |||
There was a problem hiding this comment.
would it be equivalent to add a boolean param to demandNewCompilerRun and set it true at the callsite in reload?
|
There is |
|
BTW I was curious (or annoyed) about the test; it's not my intention to muck with (or break) the PC. I assumed incorrectly that it would be a mechanism problem that required no special knowledge of PC semantics and operations. |
The "up-to-date" check is not sufficient when fetching doc comments, since a unit may have been typechecked, with doc wrapper trees removed. A test instability was due to whether the scheduler was checked by a callback or the runner thread. One sample file had no parser callbacks at all.
27a4ae7 to
11a33e4
Compare
|
I was following the "outdated symbols in the IDE" comment to which is why that doesn't drop on failed lookup, only on successful lookup of the wrong (shadowing) symbol. (I was recently reminded to look again at the 2.13.15 PR to warn about "phantom object" from the classpath: the class got a module, so the same module defined in source is hidden; the method of detection is to look in the package owner.) The test in The change in |
The "up-to-date" check is not sufficient when fetching doc comments, since a unit may have been typechecked, with doc wrapper trees removed.
A test instability was due to whether the scheduler was checked by a callback or the runner thread.
One sample file had no parser callbacks at all.
Probably the change at
demandNewCompilerRuncan be refined, as it matters just for doc comments.askParseis tweaked to submit one file at a time, since otherwise the parser callback on the first job will look for work and start the next parse. (In this test, the chain stopped there because the second file was trivial and invoked no callback.)Fixes scala/scala-dev#840