Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support Scala 3.6 in TASTy reader #10893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Support Scala 3.6 in TASTy reader #10893

merged 1 commit into from
Oct 23, 2024

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Oct 21, 2024
@SethTisue SethTisue self-assigned this Oct 21, 2024
@scala-jenkins scala-jenkins added this to the 2.13.16 milestone Oct 21, 2024
@SethTisue
Copy link
Member Author 

TestArrayAnnot.scala:5: error: exception during macro expansion:
java.lang.AssertionError: assertion failed: actually, was new SuppressWarnings(value = Array.type.apply[String]((Array[String]{"xyz", "foo"}: String*))(reflect#ClassTag.type.apply[String](classOf[java.lang.String])))
	at scala.Predef$.assert(Predef.scala:279)
	at tastytest.package$Macros$AnnotsBundle.forceAnnotsImpl(package.scala:57)

    forceAnnots[
               ^

@SethTisue SethTisue requested a review from bishabosha October 21, 2024 17:23
@SethTisue
Copy link
Member Author

@bishabosha (if you're available) what do you make of the failure?

bishabosha
bishabosha reviewed Oct 21, 2024
View reviewed changes
@SethTisue
Copy link
Member Author

might the root cause be scala/scala3#21329?

@bishabosha
Copy link
Member

bishabosha commented Oct 21, 2024 •
edited
Loading

firstly the TastyFormat.scala file should be copy-pasted (Except package name) from dotty at the 3.6.1 tag (which will update the TASTy version to 28.6.0)

not sure about this error until that is done

@SethTisue
Copy link
Member Author

I'm seeing the same error locally even after updating TastyFormat.scala

@bishabosha
Copy link
Member

bishabosha commented Oct 21, 2024 •
edited
Loading

@SethTisue the problem is a String comparison error, it expects the string "new SuppressWarnings(Array.type.apply[String]((Array[String]{\"xyz\", \"foo\"}: String*))(reflect#ClassTag.type.apply[String](classOf[java.lang.String])))" but as the error shows it now has a named argument

it should be fine to update the string in test/tasty/pos/src-2/tastytest/TestArrayAnnot.scala

@bishabosha
Copy link
Member

bishabosha commented Oct 21, 2024 •
edited
Loading

seems also that the changes to context bound desugaring to using clauses means the signature of EnumCompanion also changed.

Anyway I pushed the fix to the test sources

@SethTisue SethTisue changed the title Scala 3.6.1 (was 3.5.2-RC2) Support Scala 3.6 in TASTy reader Oct 21, 2024
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed internal not resulting in user-visible changes (build changes, tests, internal cleanups) labels Oct 21, 2024
@SethTisue SethTisue marked this pull request as ready for review October 21, 2024 22:07
@SethTisue SethTisue removed their assignment Oct 22, 2024
@SethTisue SethTisue merged commit 75a4352 into scala:2.13.x Oct 23, 2024
3 checks passed
@SethTisue SethTisue deleted the scala-3.6.1 branch October 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha left review comments

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.16
Development

Successfully merging this pull request may close these issues.
3 participants
@SethTisue @bishabosha @scala-jenkins