REPL: JLine: stop using deprecated JNA #10898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that would be great! we need to do manual testing: OSs x different terminals x (sbt, scala cli, vanilla) x ... |
|
I suggest we merge the PR so that people can easily test using a nightly build. We could always revert later if necessary, though I think that's relatively unlikely to happen. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as @Friendseeker pointed out on sbt/sbt#7811 , the JLine 3 doc says:
At the time we initially moved from JLine 2 to 3, we didn't have any particular reason for picking JNA over JNI as best I can recall; the main past discussion I can find is #8036
So, I suggest we fall in line with the new suggested default.
As well as falling in line with what sbt is doing at sbt/sbt#7811