Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2.12.x] Upgrade asm for JDK25 support#11028

Merged
SethTisue merged 1 commit into
scala:2.12.xfrom
mkurz:asm_java25
Apr 15, 2025
Merged

[2.12.x] Upgrade asm for JDK25 support#11028
SethTisue merged 1 commit into
scala:2.12.xfrom
mkurz:asm_java25

Conversation

@mkurz
Copy link
Copy Markdown
Contributor

@mkurz mkurz commented Mar 25, 2025 •
edited
Loading

It would be great if next Scala 2.12.21 could already unlock Java 25. Since v25 is a LTS I would like to test things early and not wait until ~October for a 2.12.22 release.

asm should have a release out very very soon (days hopefully) with the needed changes.

I know after asm is out we need a new scala-asm release, but that should a no brainer.

If this would slip into 2.12.21 that would be nice.

@scala-jenkins scala-jenkins added this to the 2.12.22 milestone Mar 25, 2025
@SethTisue SethTisue modified the milestones: 2.12.22, 2.12.21 Mar 25, 2025
@SethTisue SethTisue added the prio:hi high priority (used only by core team, only near release time) label Mar 25, 2025
@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Mar 25, 2025

Thank you for bringing this to our attention. Yes, looks like waiting for this makes sense.

@mkurz
Copy link
Copy Markdown
Contributor Author

mkurz commented Mar 26, 2025

Update: The asm release should happen this weekend: https://gitlab.ow2.org/asm/asm/-/issues/318029#note_109210

@mkurz
Copy link
Copy Markdown
Contributor Author

mkurz commented Mar 31, 2025

asm 9.8 released:

@SethTisue will you update https://github.com/scala/scala-asm?

@SethTisue SethTisue self-assigned this Apr 14, 2025
@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Apr 14, 2025

this is going to hit the same TrapExit thing as #11022 , I think

@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Apr 14, 2025

there's no TrapExit failure because we aren't building on JDK 24 or 25 during PR validation, only after merge

@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Apr 14, 2025 •
edited
Loading

oh, and we can't just run CI on 25-ea here; we must merge the ASM upgrade, then re-STARR, then add 25-ea to the matrix

I'll come back to this tomorrow

@SethTisue

This comment was marked as outdated.

Sign in to view
@SethTisue
Copy link
Copy Markdown
Member

SethTisue commented Apr 15, 2025 •
edited
Loading

fine to merge this as-is and then deal with re-STARRing (and adding 25 to the CI matrix) in a separate PR (and after that PR, merge it all forward onto 2.13.x)

@SethTisue SethTisue marked this pull request as ready for review April 15, 2025 20:28
@SethTisue SethTisue enabled auto-merge April 15, 2025 20:28
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Apr 15, 2025
@SethTisue SethTisue merged commit edac1eb into scala:2.12.x Apr 15, 2025
3 checks passed
@mkurz mkurz deleted the asm_java25 branch April 16, 2025 06:11
@eed3si9n eed3si9n mentioned this pull request Sep 18, 2025
Closed
@xuwei-k xuwei-k mentioned this pull request Oct 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SethTisue SethTisue

Labels

prio:hi high priority (used only by core team, only near release time) release-notes worth highlighting in next release notes

Projects

None yet

Milestone

2.12.21

Development

Successfully merging this pull request may close these issues.

3 participants

@mkurz @SethTisue @scala-jenkins