Use toVector for XML literal sequences
#11065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went for |
|
|
In `<a><b/><c/><a>`, a `NodeBuffer` (which extends `ArrayBuffer`) is
used to accumulate the children. The buffer is passed to
`new Elem($buf: _*)`, which only works thanks to the implicit
`collection.Seq[Node] => NodeSeq` declared in scala-xml.
With `-Vprint:typer`:
```scala
scala> <a><b/></a>
[[syntax trees at end of typer]] // <console>
private[this] val res0: scala.xml.Elem = new scala.xml.Elem(null, "a", scala.xml.Null, scala.xml.TopScope, false, (xml.this.NodeSeq.seqToNodeSeq({
val $buf: scala.xml.NodeBuffer = new scala.xml.NodeBuffer();
$buf.&+(new scala.xml.Elem(null, "b", scala.xml.Null, scala.xml.TopScope, true));
$buf
}): _*));
```
The implicit was not inserted in 2.12 because the varargs parameter of
Elem accepted a `collection.Seq`.
SethTisue
approved these changes
Aug 8, 2025
|
eligible for forward-port to Scala 3? |
|
That's already done: scala/scala3#23221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
<a><b/><c/><a>, aNodeBuffer(which extendsArrayBuffer) is used to accumulate the children. The buffer is passed tonew Elem($buf: _*), which only works thanks to the implicitcollection.Seq[Node] => NodeSeqdeclared in scala-xml.With
-Vprint:typer:The implicit was not inserted in 2.12 because the varargs parameter of Elem accepted a
collection.Seq.