Port summonIgnoring from 3.7 as c.inferImplicitValueIgnoring#11068
Merged
lrytz merged 1 commit intoJun 16, 2025
Conversation
Contributor
|
We ought to encourage more tickets and PRs with links to youtube or tiktok! My favorite bit so far is the correct pronunciation of Circe. |
|
correct??
first come first serve! |
Contributor
|
I tried to get that pedantic line adjusted years ago but wasn't successful. I think pedantry calls for correctness. That could be called "a pedant's mismatch". (I mean the Attic pronunciation.) |
lrytz
approved these changes
Jun 16, 2025
Member
lrytz
left a comment
There was a problem hiding this comment.
LGTM, thanks @MateuszKubuszok and sorry for the delay!
Contributor
Author
|
Thanks! |
This was referenced Jun 16, 2025
summonIgnoring from 3.7 as c.inferImplicitValueIgnoring
Member
|
@lrytz did you omit this from the 2.13.18 release notes on purpose? |
Member
|
This was already merged for 2.13.17 and is listed in those release notes (https://github.com/scala/scala/releases/tag/v2.13.17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports
Expr.summonIgnoringthat was introduced in 3.7.0.On 3.7.0 it allowed:
However, it increased the maintenance burden on such libraries since they need to implement 2 different hierarchies to keep the behavior consistent. It might also burden users who would like to use such libraries and cross-compile their codebases.
By adding just 1 public macro method - and keeping the behavior and signatures of all the other methods unchanged - libraries that use such solutions to improve the QoL of their users could have once again align how the code looks and behaves, preventing unnecessary friction during the 2->3 migration process.