Check Any-typed if/match in toString lint #11074
Draft
+82
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Position of diagnostic for |
lrytz
reviewed
Jun 16, 2025
| if (linting && !(arg.tpe =:= definitions.StringTpe)) | ||
| def warn(msg: String) = runReporting.warning(arg.pos, msg, WFlagTostringInterpolated, c.internal.enclosingOwner) | ||
| def stringlyBranches = arg match { | ||
| case If(_, thenp, elsep) => thenp.tpe <:< definitions.StringTpe && elsep.tpe <:< definitions.StringTpe |
There was a problem hiding this comment.
non-unit primitives should be allowed
scala> def f(b: Boolean) = s"b: ${if (b) 1 else 0}"
^
warning: interpolation uses toString
def f(b: Boolean): StringThere was a problem hiding this comment.
Also nesting..
scala> def f(x: Any) = s"r: ${ x match { case s: String => s; case _ => if (x == null) "n" else "s" } }"
^
warning: interpolation uses toString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#13107
Since interpolated expressions have an expected type
Any,ifandmatchexpressions areAny-typed.Before warning about them, check whether the "arms" or "branches" ("else" or "case") conform to
String.