Prevent accidentally dropping annotations#11173
Merged
Merged
Conversation
som-snytt
approved these changes
Nov 4, 2025
Contributor
som-snytt
left a comment
There was a problem hiding this comment.
I never met a Anne O'Tayshun I didn't like.
When target annotations `@(deprecated @Getter)` were introduced, all annotations in the package `annotation.meta` were target annotations. In the meantime there are others, which broke annotation filtering. ``` def mkFilter(category: Symbol, defaultRetention: Boolean)(ann: AnnotationInfo) = (ann.targetAnnotations, ann.defaultTargets) match { case (Nil, Nil) => defaultRetention case (Nil, defaults) => defaults contains category case (metas, _) => metas exists (_ matches category) } ``` we ended up in the second case with `defaults` being the `superArg` meta annotation, which is not a target annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly define "target meta annotations" in the compiler.
When target annotations
@(deprecated @getter)were introduced, all annotations in the packageannotation.metawere target annotations.In the meantime there are others, which broke annotation filtering.
we ended up in the second case with
defaultsbeing thesuperArgmeta annotation, which is not a target annotation.Fixes scala/bug#13140