Defer parameter alias computation until the end of typechecking #6301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
requested changes
Apr 15, 2018
| @@ -49,6 +49,7 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper | |||
| private val rightAssocValDefs = new mutable.AnyRefMap[Symbol, Tree] | |||
| // Symbols of ValDefs for right-associative operator desugaring which are passed by name and have been inlined | |||
| private val inlinedRightAssocValDefs = new mutable.HashSet[Symbol] | |||
| private val superConstructorCalls: mutable.AnyRefMap[Symbol, collection.Map[Symbol, Symbol]] = perRunCaches.newAnyRefMap() | |||
There was a problem hiding this comment.
Could you add a comment for the structure of the map?
| @@ -5919,6 +5917,34 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper | |||
| if (phase.erasedTypes) None // OPT save the hashmap lookup in erasure type and beyond | |||
| else transformed remove tree | |||
| } | |||
|
|
|||
|
|
|||
| /** Finish computation of param aliases after typechecking is completed */ | |||
There was a problem hiding this comment.
It would be nice to have a (very short) summary what happens with param aliases (or say where it's documented)...
There was a problem hiding this comment.
I've added a few comments with my best reverse engineering of the intent.
Previously, it was done while typechecking super calls, and would fail to see the fact that a yet-to-be-typechecked super constructor itself had a parameter aliased by a grand-parent class.
|
Ping @lrytz |
lrytz
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was done while typechecking super calls, and would fail
to see the fact that a yet-to-be-typechecked super constructor itself
had a parameter aliased by a grand-parent class.
Part of scala/scala-dev#405