Don't copy the OVERRIDE flag in refinement decls #6302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15937e6 to
72d2c1f
Compare
72d2c1f to
5c27130
Compare
5c27130 to
616f364
Compare
616f364 to
bbcd5f7
Compare
|
/synch |
bbcd5f7 to
9148add
Compare
|
Needs a rebase |
9d204fc to
2ea7f52
Compare
typedRefinement defers the setting of this flag until the end of the compilation unit, which means that inferred types that are derived from the written refinement type can be unstable depending on whether they were computed before or after the flag was set. An alternative fix might be to just remove the setting of OVERRIDE in typedRefinement.unitToCheck.
2ea7f52 to
f6ca3dd
Compare
|
Rebased, LGTM. @adriaanm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typedRefinementdefers the setting of this flag until the end of thecompilation unit, which means that inferred types that are derived from the
written refinement type can be unstable depending on whether they were
computed before or after the flag was set.
An alternative fix might be to just remove the setting of
OVERRIDEinin
typedRefinement.unitToCheck.The (last!) part of scala/scala-dev#405
Includes the commits of #6300 as it adds a new test case to
DeterminismTest. Only the final commit is the subject of this pull request.