Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change Predef.$conforms type from A <:< A to A => A #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 24, 2018

As suggested in the comment above $conforms


This PR depends on #7350, only the last commit is new.

@lrytz
Copy link
Member

lrytz commented Oct 26, 2018

I guess this is the least risky change for $conforms. LGTM.

@smarter
Copy link
Member Author

smarter commented Oct 26, 2018

What more risky change did you have in mind? :)

@lrytz
Copy link
Member

lrytz commented Oct 26, 2018

Rename it (as it's now just an implicit identity), or move it to the companion of Function1. But since we don't have a strong reason to do any of that, it's probably better not to.

@SethTisue

This comment has been minimized.

@smarter smarter force-pushed the change-predef-conforms branch from 539b8f1 to 915486c Compare October 31, 2018 14:29
@lrytz
Copy link
Member

lrytz commented Dec 14, 2018

@smarter could you rebase this one?

As suggested in the comment above $conforms
@smarter smarter force-pushed the change-predef-conforms branch from 915486c to 673b6f6 Compare December 14, 2018 13:04
@smarter
Copy link
Member Author

smarter commented Dec 14, 2018

Done.

@lrytz lrytz merged commit 141f6cb into scala:2.13.x Dec 17, 2018
@lrytz
Copy link
Member

lrytz commented Dec 17, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants