Amend mumurhash3 doc to remind users to check hashes in between versions #9051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…volving hashing algorithms.
|
thank you! (and, apologies for letting this sit so long) |
indeed, and see also https://dzone.com/articles/the-magic-word-in-java-cafebabe |
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
…oc/11646 Amend mumurhash3 doc to remind users to check hashes in between versions
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
…oc/11646 Amend mumurhash3 doc to remind users to check hashes in between versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes scala/bug#11646
Adds instructive reminder for users of
MurmurHash3, about the nature of this algorithm. The initially added lines are a direct distillation of Ichoran's comment. I'm describing this as initially because I think the lines are a bit loaded, unless it's clear enough?PS: Can I consider
final val productSeed = 0xcafebabean easter egg?