Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Try to add 2.13.0-M5 support #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2018
Merged

Try to add 2.13.0-M5 support #204

merged 3 commits into from
Dec 13, 2018

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Nov 27, 2018 •
edited
Loading

Opening this in case this can be of any help… two tests still fail:

$ sbt ++2.13.0-M5 test
[…]
[error] Test scala.async.run.futures.FutureSpec.A future with custom ExecutionContext should handle Throwables failed: assertion failed: 0 is not 4, took 1.01 sec
[error] Test scala.async.run.futures.FutureSpec.support pattern matching within a for-comprehension failed: scala.concurrent.Future$$anon$2: Future.filter predicate is not satisfied, took 0.019 sec
[error] Failed: Total 180, Failed 2, Errors 0, Passed 178
[error] Failed tests:
[error] 	scala.async.run.futures.FutureSpec
[error] (test:test) sbt.TestsFailedException: Tests unsuccessful

@adriaanm adriaanm self-assigned this Nov 27, 2018
@adriaanm
Copy link
Contributor

Thanks! I'll take a look

@SethTisue
Copy link
Member

@viktorklang I wonder if this might have to do with your Future changes

@viktorklang
Copy link
Contributor

@SethTisue I believe the exception message changed and this test might not accommodate for that?

@alexarchambault
Copy link
Contributor Author

Just reported changes from https://github.com/scala/scala/tree/2.13.x/test/files/jvm/future-spec here, which seems to have fixed the two failing tests (last two commits).

@adriaanm
Copy link
Contributor

thanks, @alexarchambault!

@adriaanm adriaanm merged commit 6d3cecb into scala:master Dec 13, 2018
@alexarchambault alexarchambault deleted the topic/scala-2.13.0-M5 branch December 13, 2018 15:14
@alexarchambault
Copy link
Contributor Author

alexarchambault commented Dec 14, 2018 •
edited
Loading

Would it be possible to release a version with 2.13.0-M5 support? (new one, or 0.9.7 with the changes of that PR)

@adriaanm
Copy link
Contributor

adriaanm commented Dec 18, 2018 •
edited
Loading

done! (at https://oss.sonatype.org/content/repositories/releases/org/scala-lang/modules/scala-async_2.13.0-M5/0.9.7/)

@alexarchambault
Copy link
Contributor Author

@adriaanm Thanks!

@SethTisue
Copy link
Member

scala/make-release-notes@e8f0958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adriaanm adriaanm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexarchambault @adriaanm @SethTisue @viktorklang