Fix #4: multiple JDKs#19
Merged
Merged
Conversation
Member
|
Looks plausible to me. Where would we switch the JDK for 2.12.x (when we're ready to do so)? |
Contributor
Author
|
We'd have to make the default value for the job's parameter a function of the target branch. Doable, but not yet implemented. |
Contributor
Author
|
I added a note to the corresponding ticket. Will merge this and tag v0.1.0! Time for me to context switch to PR reviews/release planning tomorrow. |
adriaanm
added a commit
to adriaanm/scala-jenkins-infra
that referenced
this pull request
Jan 30, 2015
adriaanm
added a commit
to adriaanm/scala-jenkins-infra
that referenced
this pull request
Feb 3, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Chef's view of our recipe differs from github (should fix that), we're already running this in production. Verified to work on ubuntu at least: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-bootstrap/25
care to have a quick look, @retronym?