chore: make a few adjustments to merge the scala2 stdlib #23527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
approved these changes
Jul 15, 2025
| @@ -155,11 +155,15 @@ class BootstrappedOnlyCompilationTests { | |||
|
|
|||
| @Test def picklingWithCompiler: Unit = { | |||
| implicit val testGroup: TestGroup = TestGroup("testPicklingWithCompiler") | |||
| // Exclude this file from the test as it contains some changes that require scala 2.13.17 | |||
| // This filter can be dropped once we drop the dependency to Scala 2 (in 3.8.0) | |||
There was a problem hiding this comment.
NIT
Suggested change
| // This filter can be dropped once we drop the dependency to Scala 2 (in 3.8.0) | |
| //TODO: This filter can be dropped once we drop the dependency to Scala 2 (in 3.8.0) |
hamzaremmal
commented
Jul 15, 2025
| @@ -29,7 +29,7 @@ class TastyBootstrapTests { | |||
| * bootstrapped, and making sure that TASTY can link against a compiled | |||
| * version of Dotty, and compiling the compiler using the SemanticDB generation | |||
| */ | |||
| @Test def tastyBootstrap: Unit = { | |||
| @Ignore @Test def tastyBootstrap: Unit = { | |||
There was a problem hiding this comment.
I will undo this change once I merge #23522 and ignore AnyVal.scala
hamzaremmal
added a commit
that referenced
this pull request
Jul 15, 2025
dotty is not able to compile `scala.AnyVal` from source. We ignore the source file of `scala.AnyVal` for now. ~We also partially revert #23527 to enable back a disabled test because of the reason mentioned before.~ EDIT: enabling the test back requires to fix the issue with `-Ycheck`, (which cannot be fixed before 3.8.0? at least not fully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to merge #23522, we need to make some adjustments to the tests and undo them later when the stdlib will be fully independent of scala 2.
[skip ci]