Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove js.use(x).as[T] #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjrd opened this issue May 12, 2017 · 4 comments
Closed

Remove js.use(x).as[T] #2948

sjrd opened this issue May 12, 2017 · 4 comments
Assignees
@gzm0
Labels
enhancement Feature request (that does not concern language semantics, see "language")
Milestone
v1.0.0-M1

Comments

@sjrd
Copy link
Member

sjrd commented May 12, 2017

There are 3 good reasons for that:

  • It definitely can be implemented and tested outside of the core, so it should.
  • With Scala.js-defined JS classes, this feature has lost a lot of its usefulness (GitHub reports 2 occurrences of js.use in .scala files in the wild, and one of them should really be a Scala.js-defined JS class).
  • It is the only macro in the core library, so getting rid of it means getting rid of all macros in the core lib.
@sjrd sjrd added the enhancement Feature request (that does not concern language semantics, see "language") label May 12, 2017
@sjrd sjrd added this to the v1.0.0 milestone May 12, 2017
@sjrd sjrd changed the title Move js.use(x).as[T] outside of the core Move js.use(x).as[T] out of the core May 12, 2017
@gzm0
Copy link
Contributor

gzm0 commented May 20, 2017

I definitely agree. I'm wondering whether we should just remove it and revive it if somebody asks for it.

@gzm0
Copy link
Contributor

gzm0 commented May 20, 2017

I propose the following:

  • Deprecate in 0.6.17.
  • Remove in 1.0.0 (without replacement).
  • Revive if necessary.

@sjrd
Copy link
Member Author

sjrd commented May 20, 2017

I'm not a big fan of deprecating without replacement in 0.6.17. Because if people do use it and use fatal warnings, it's too much breakage in a minor release.

I'd actually rather just remove it in 1.0.0 without replacement, and revive if necessary.

@gzm0
Copy link
Contributor

gzm0 commented May 20, 2017

Fair enough :)

@gzm0 gzm0 self-assigned this May 20, 2017
@gzm0 gzm0 changed the title Move js.use(x).as[T] out of the core Remove js.use(x).as[T] May 20, 2017
@sjrd sjrd closed this as completed in 9fec009 May 21, 2017
sjrd added a commit that referenced this issue May 21, 2017
@sjrd
Merge pull request #2959 from gzm0/no-js-use-as
0422083 
Fix #2948: Remove js.use(x).as[T]
@gzm0 gzm0 mentioned this issue Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
enhancement Feature request (that does not concern language semantics, see "language")
Projects
None yet
Milestone
v1.0.0-M1
Development

No branches or pull requests
2 participants
@sjrd @gzm0