Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #3975: Upgrade GCC to v20200315 #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix #3975: Upgrade GCC to v20200315 #3997

merged 2 commits into from
Mar 24, 2020

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Mar 23, 2020

No description provided.

@gzm0 gzm0 requested a review from sjrd March 23, 2020 16:59
@gzm0 gzm0 linked an issue Mar 23, 2020 that may be closed by this pull request
helloworld2_12/fullOptJS fails with GCC v20200112 onward #3975
Closed
sjrd
sjrd approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waw, that was subtle! Thank you for figuring this out!

@gzm0
Copy link
Contributor Author

gzm0 commented Mar 23, 2020

Turns out LanguageMode has toFeatureSet method. I updated the PR to use that.

@gzm0 gzm0 requested a review from sjrd March 23, 2020 18:41
@sjrd
Copy link
Member

sjrd commented Mar 24, 2020

There are 2 MiMa errors in the linker.

@gzm0
Fix scala-js#3975: Upgrade GCC to v20200315
164e321 
Starting v20200112, GCC validates the advertised features of the input
later in the pipeline. This made compilation on ES2015 fail.

We update ClosureAstTransformer to properly advertise its own feature
set.
@gzm0 gzm0 requested a review from sjrd March 24, 2020 08:36
@gzm0 gzm0 added this to the v1.1.0 milestone Mar 24, 2020
@gzm0 gzm0 merged commit 42ee039 into scala-js:master Mar 24, 2020
@gzm0 gzm0 removed this from the v1.1.0 milestone Mar 24, 2020
@gzm0 gzm0 deleted the upgrade-gcc branch March 24, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helloworld2_12/fullOptJS fails with GCC v20200112 onward
2 participants
@gzm0 @sjrd