Use standard loading mechanism for jl.Object in Analyzer #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
commented
Aug 5, 2023
| @@ -216,8 +215,6 @@ object Analysis { | |||
|
|
|||
| def logError(error: Error, logger: Logger, level: Level): Unit = { | |||
| val headMsg = error match { | |||
| case MissingJavaLangObjectClass(_) => | |||
| "Fatal error: java.lang.Object is missing" | |||
There was a problem hiding this comment.
@sjrd, if you feel we need to keep this error, we have two alternatives:
- Emit it in addition when the lookup of
ObjectClassreturns anonExistentClass - Special case
ClassInfo#linkto emit a different error ifclassName == ObjectClass(there is precedent forClassInfoto behave differently if it is jlO, so it's not that bad).
There was a problem hiding this comment.
The special error was only there because I thought it would crash the rest of the Analyzer if Object was missing. If it doesn't crash, it's fine.
Perhaps add a test where jl.Object is missing but there actually is another class? Currently the only test we have has no class at all.
7fbac61 to
5ae12d4
Compare
5ae12d4 to
4fe66ec
Compare
|
FWIW: Maybe we should split this into two commits. LMK if you'd like me to do this. |
4fe66ec to
c58c82b
Compare
|
I have:
|
sjrd
approved these changes
Aug 5, 2023
The Analyzer is built with the assumption that the number of pending tasks never drops to zero until the whole analysis is completed. However, our loading sequence violated this assumption: since the constructor of LoadingClass scheduled info loading immediately, it was possible for info loading to complete before linking is requested on the class. If this condition happens on the initial calling thread (which itself is not tracked as a "task"), the pending task count would drop to zero.
Discovered as a simplification while working on scala-js#1626.
c58c82b to
42cd08d
Compare
|
sjrd
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered as a simplification while working on #1626.
This also exposes a latent bug in the class loading sequence: the
Analyzer is built with the assumption that pending tasks never drop to
zero until the whole analysis is completed.
However, our loading sequence violated this assumption: since the
constructor of LoadingClass scheduled info loading immediately, it was
possible for info loading to complete before linking is requested on
the class. If this condition happens on the initial calling
thread (which itself is not tracked as a "task"), the pending task
count would drop to zero.