Emitter changes to fuse JS emitting and printing #4922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b022be to
a65db04
Compare
|
I have added a commit to use |
sjrd
approved these changes
Jan 23, 2024
| ctor, // invalidated directly | ||
| memberMethods, // invalidated directly | ||
| exportedMembers.flatten // invalidated directly | ||
| ctor ++ memberMethods ++ exportedMembers.flatten // all 3 invalidated directly |
There was a problem hiding this comment.
If these are all Lists, ::: is more efficient:
Suggested change
| ctor ++ memberMethods ++ exportedMembers.flatten // all 3 invalidated directly | |
| ctor ::: memberMethods ::: exportedMembers.flatten // all 3 invalidated directly |
57c062c to
f40cd0d
Compare
sjrd
approved these changes
Jan 28, 2024
This allows us to invalidate generated exported members less often (and in following commits, also class members).
Now that we have it, we might as well save some memory.
This simplifies buildClass. Thanks to the special version for isJSClass, this will lead to acceptable invalidations (only if the class kind changes, which should be rare).
This removes the only desugarExpr call from buildClass. Since we'll stop caching buildClass going forward, this is important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.