Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace DocComment tree with dedicated JSDocConstructor tree #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Dec 30, 2023

This simplifies pretty much all usage sites.

@gzm0
Copy link
Contributor Author

gzm0 commented Dec 30, 2023

Draft because it depends on #4920.

@gzm0 gzm0 force-pushed the no-doc-comment branch 2 times, most recently from 984685b to 80c15a1 Compare January 2, 2024 13:13
@gzm0 gzm0 requested a review from sjrd January 2, 2024 15:10
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #4920 gets merged and this is rebased.

This simplifies pretty much all usage sites.
@gzm0 gzm0 marked this pull request as ready for review January 28, 2024 15:46
@gzm0
Copy link
Contributor Author

gzm0 commented Jan 28, 2024

Rebased. Ready to be merged once CI passes.

@sjrd sjrd merged commit 51a363e into scala-js:main Jan 29, 2024
@gzm0 gzm0 deleted the no-doc-comment branch January 29, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants