Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not put O (jl.Object) in the ancestors dictionaries. #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jan 28, 2024

It is never read, because all the functions that would read it are special-cased, so these are wasted bytes.


Extracted from #4930 as suggested.

@sjrd sjrd requested a review from gzm0 January 28, 2024 10:52
@sjrd sjrd marked this pull request as draft January 28, 2024 12:03
@sjrd
Copy link
Member Author

sjrd commented Jan 28, 2024

Converting to draft to make sure we merge #4920 first. It contains several commits affecting the generated size, so it will be easier to rebase this PR on top of #4920 than the other way around.

@gzm0 gzm0 marked this pull request as ready for review January 28, 2024 15:45
@gzm0
Copy link
Contributor

gzm0 commented Jan 28, 2024

#4920 is in. This is ready for rebase and merge.

It is never read, because all the functions that would read it are
special-cased, so these are wasted bytes.
@sjrd sjrd force-pushed the no-jlobject-in-ancestors-dicts branch from 8c8ef38 to 6d07255 Compare January 28, 2024 15:55
@sjrd sjrd merged commit 586966e into scala-js:main Jan 28, 2024
@sjrd sjrd deleted the no-jlobject-in-ancestors-dicts branch January 28, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants