Add LinkedClass.hasDirectInstances. #4960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
requested changes
Mar 16, 2024
linker/shared/src/main/scala/org/scalajs/linker/backend/emitter/Emitter.scala
Outdated
Show resolved
Hide resolved
gzm0
approved these changes
Mar 16, 2024
aafcbb7 to
bacbecf
Compare
It exposes whether the given class is directly instantiated. This is required for the WebAssembly backend, which needs to build vtables for concrete classes only.
It is not useful for classes that only have strict sub instances, i.e., classes that are effectively abstract.
bacbecf to
f05baed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rebased on top of #4931 once it's merged, because of the second commit. Otherwise good to review.
It exposes whether the given class is directly instantiated. This is required for the WebAssembly backend, which needs to build vtables for concrete classes only.
The second commit only has a marginal impact, because the condition
&& linkedClass.hasRuntimeTypeInfoalmost entirely compensated for the former imprecision, but it is free lunch after the first one.