Remove coreSpec from ModuleSet / LinkingUnit and verifyModuleSet #5104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core spec is configuration, not a part of the linking unit. One could argue that `verifyModuleSet` adds a little bit of safety, but IMO, it does not warrant the cost / boilerplate of copying coreSpec around everywhere.
sjrd
approved these changes
Jan 5, 2025
|
I'm not 100% sure whether this is a good thing or not. I can see how having the |
|
Makes sense. The check that is really meaningful is already here, IMO: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core spec is configuration, not a part of the linking unit.
One could argue that
verifyModuleSetadds a little bit of safety, but IMO, it does not warrant the cost / boilerplate of copying coreSpec around everywhere.It felt like we might want to do this, when I looked at #5101.