Reorganize LinkTimeProperties. #5163
Merged
+50
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
approved these changes
May 7, 2025
| @@ -118,7 +120,7 @@ final class Desugarer(config: CommonPhaseConfig, checkIR: Boolean) { | |||
|
|
|||
| private[linker] object Desugarer { | |||
|
|
|||
| private final class DesugarTransformer(coreSpec: CoreSpec) | |||
| private final class DesugarTransformer(linkTimeProperties: LinkTimeProperties) | |||
| implicit val pos = tree.pos | ||
| val value = linkTimeProperties.get(name).getOrElse { | ||
| throw new IllegalArgumentException( | ||
| s"link time property not found: 'name' of type ${tree.tpe}") |
There was a problem hiding this comment.
Suggested change
| s"link time property not found: 'name' of type ${tree.tpe}") | |
| s"link time property not found: '$name' of type ${tree.tpe}") |
| def tpe: Type = this match { | ||
| case LinkTimeInt(_) => IntType | ||
| case LinkTimeBoolean(_) => BooleanType | ||
| case LinkTimeString(_) => StringType |
There was a problem hiding this comment.
Nit: Instead of self matching, pass the type as val constructor param to LinkTimeValue?
* Move it to `frontend`. * Make it public. * Move the logic of `validate` and `transformLinkTimeProperty` to their respective call sites. * Construct them from a CoreSpec, rather than being contained by CoreSpec. These changes better isolate the data (`LinkTimeProperties`) from the transformations we apply to that data (the logic in `Analyzer` and `Desugarer`).
55ff3cf to
fd90409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend.validateandtransformLinkTimePropertyto their respective call sites.These changes better isolate the data (
LinkTimeProperties) from the transformations we apply to that data (the logic inAnalyzerandDesugarer).