Further optimize Math.rint using a floating point splitting technique. #5200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show that this is markedly faster than the previous implementation. That is unsurprising, as the
js.Math.round
algorithm basically had to handle x.5 values twice on top of the primitive hardware rounding function (once insidejs.Math.round
to turn ties-to-even into ties-up; and once in our algorithm to turn ties-up back to ties-to-even).