Fix #5231: Partial revert of "Fail if we cannot inline RuntimeLong". #5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
approved these changes
Sep 5, 2025
…eLong". This commit partially reverts 3a253e3. It turns out that an expanded `RuntimeLong` *can* be canceled, in some corner case scenarios. There might be a proper fix to the underlying issue, but in the meantime, let the cancellation happen.
8dc4f6f to
474d6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts 3a253e3.
It turns out that an expanded
RuntimeLongcan be canceled, in some corner case scenarios. There might be a proper fix to the underlying issue, but in the meantime, let the cancellation happen.Will need a force-amend after #5230 is merged so that the "Towards 1.20.1" commit doesn't appear to belong to this PR.