I ran the 'full' CI for this PR, in order to test all the Scala versions. It did pass. the sbt plugin is probably the only project that we only compile with 2.12.20, and not every 2.12.x that we support.

So we could take this. Is this the only thing required to make the sbt plugin build without warning under Scala 3, though? How much more of these changes do we expect?

Is this the only thing required to make the sbt plugin build without warning under Scala 3, though? How much more of these changes do we expect?

I think not only this changes. Can't actually know until I actually try it.

We should have a comprehensive view of what needs to be done before we start merging things like this. There's no point creating a mix of Scala 2 and 3 syntax in our repo if we don't manage to fully solve the issue.

Especially for warnings, there is always the alternative of ignoring warnings when compiling with Scala 3.

If the new syntax is supported with the 2.12.x versions that needs supporting, wouldn't it make sense to just make this change for the whole repo?

The rest of the repo still builds with 2.12.6, so no.

I guess I read the above incorrectly and I did not know the 2.12 version where the change got added.

scala/scala@6d2ca69