Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Headers#get won't return undefined but typed as js.UndefOr #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
unarist opened this issue Feb 9, 2021 · 0 comments
Closed

Headers#get won't return undefined but typed as js.UndefOr #445

unarist opened this issue Feb 9, 2021 · 0 comments
Assignees
@armanbilge
Labels
bug

Comments

@unarist
Copy link
Contributor

unarist commented Feb 9, 2021

The headers#get method returns a header value or null. So this method won't return undefined. but it's typed with js.UndefOr.
https://developer.mozilla.org/en-US/docs/Web/API/Headers/get

scala-js-dom/src/main/scala/org/scalajs/dom/experimental/Fetch.scala

Line 312 in 5a502ad

def get(name: ByteString): js.UndefOr[ByteString] = js.native

armanbilge added a commit that referenced this issue Aug 11, 2021
@armanbilge
Fix #445 return type for Header#get
4fe536d
@armanbilge armanbilge self-assigned this Aug 11, 2021
@armanbilge armanbilge added the bug label Aug 11, 2021
@armanbilge armanbilge mentioned this issue Aug 12, 2021
Merged
japgolly pushed a commit that referenced this issue Aug 20, 2021
@armanbilge @japgolly
Fix #445 return type for Header#get
bcfd017
japgolly added a commit that referenced this issue Aug 20, 2021
@japgolly
Merge pull request #473 from scala-js/issue/445
c9f60ce 
Fix #445 return type for Header#get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanbilge armanbilge

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unarist @armanbilge