Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Missing Element.remove #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OndrejSpanel opened this issue Apr 30, 2021 · 2 comments · Fixed by #561
Closed

Missing Element.remove #447

OndrejSpanel opened this issue Apr 30, 2021 · 2 comments · Fixed by #561
Labels
enhancement help wanted

Comments

@OndrejSpanel
Copy link

It seems DOM Element (in org.scalajs.dom.raw) misses the remove method.

It can be replaced by e.parentNode.removeChild(e), but I think there is probably no reason not to add it.
@strelec
Copy link

strelec commented Jul 11, 2021 •
edited
Loading

Many more elementary DOM operations are missing (all of them very well supported in the browsers):

	@js.native
	trait ElementExt extends HTMLElement {
		def remove(): Unit = js.native
		def before(nodes: Node*): Unit = js.native
		def after(nodes: Node*): Unit = js.native

		def replaceChildren(nodes: Node*): Unit = js.native
		def prepend(nodes: Node*): Unit = js.native
		def append(nodes: Node*): Unit = js.native
	}

@armanbilge
Copy link
Member

@strelec would you mind opening a PR with those additions please? Would be much much appreciated!

japgolly added a commit that referenced this issue Sep 6, 2021
@japgolly
Add remove and other missing Element methods
a423492 
Fixes #447
@japgolly japgolly mentioned this issue Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add remove and other missing Element methods scala-js/scala-js-dom
3 participants
@armanbilge @strelec @OndrejSpanel