Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTMLAudioElement.play should return Promise, not Unit #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
strelec opened this issue Aug 15, 2021 · 0 comments
Closed

HTMLAudioElement.play should return Promise, not Unit #488

strelec opened this issue Aug 15, 2021 · 0 comments
Assignees
@armanbilge
Labels
bug

Comments

@strelec
Copy link

strelec commented Aug 15, 2021 •
edited
Loading

This should be a backwards-compatible change.

https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/play

The HTMLMediaElement play() method attempts to begin playback of the media. It returns a Promise which is resolved when playback has been successfully started. Failure to begin playback for any reason, such as permission issues, result in the promise being rejected.
@armanbilge armanbilge added the bug label Aug 15, 2021
@armanbilge armanbilge self-assigned this Aug 15, 2021
armanbilge added a commit that referenced this issue Aug 15, 2021
@armanbilge
Fix #488 HTMLAudioElement.play should return Promise
819e15a
armanbilge added a commit that referenced this issue Aug 15, 2021
@armanbilge
Fix #488 HTMLMediaElement.play() should return Promise
73cab73
japgolly added a commit that referenced this issue Aug 20, 2021
@japgolly
Merge pull request #491 from scala-js/issue/488
116cc24 
Fix #488 `HTMLMediaElement.play()` should return `Promise`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanbilge armanbilge

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armanbilge @strelec