Fix docs examples #426
Merged
Fix docs examples #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Oct 8, 2020
| "http://api.openweathermap.org/" + | ||
| "data/2.5/weather?q=Singapore" | ||
| ) | ||
| xhr.open("GET", "https://www.boredapi.com/api/activity") |
There was a problem hiding this comment.
These examples show up in the final document next to their output, and hence they only have ~40 characters a line. We should try to keep lines as short as possible:
Suggested change
| xhr.open("GET", "https://www.boredapi.com/api/activity") | |
| xhr.open("GET", | |
| "https://www.boredapi.com/api/activity") |
| xhr.onload = { (e: dom.Event) => | ||
| if (xhr.status == 200) { | ||
| pre.textContent = | ||
| xhr.responseText | ||
| pre.textContent = xhr.responseText |
There was a problem hiding this comment.
Same problem here. The previous formatting was better for the short line width.
| val url = | ||
| "http://api.openweathermap.org/" + | ||
| "data/2.5/weather?q=Singapore" | ||
| val url = "https://www.boredapi.com/api/activity" |
There was a problem hiding this comment.
Suggested change
| val url = "https://www.boredapi.com/api/activity" | |
| val url = | |
| "https://www.boredapi.com/api/activity" |
|
Makes sense. All addressed now! @sjrd |
sjrd
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements: