-
Notifications
You must be signed in to change notification settings - Fork 161
Add WindowOrWorkerGlobalScope #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WindowOrWorkerGlobalScope #430
Conversation
Oh no. I now see two things.
Regarding the surface area of this PR that intersects with #416, this PR is more accurately typed. The only concern with this PR is that it is incomplete. We can either merge this first and then follow up with a revised #416, or combine this and #416 to form a new PR. @sjrd please let us know which you'll allow and we'll make it happen. @exoego Happy to work together to combine our PRs, or if you couldn't be bothered anymore, I'm happy to integrate your PR into mine. Yours did come first after all :D よろしくお願いします |
np @exoego I'll combine our PRs in the next few days. 👍 And thanks for your work there. I've got so much other work to be doing so I think I'd cry if I myself had to write all the new facades in your PR 😅 |
A few days, a month, they're the same thing right? Hmmm.... Moving on. I've merged #416 into this PR and made a few little fixes. This is good to go now. |
Yeah I have already. I did on 15th Dec 2020. There's a comment right above yours @exoego 😄 |
8acd9d0
to
71126c1
Compare
Did a rebase. |
For scalajs-dom 2.x, which doesn't have to support Scala.js 0.6.x, a much better alternative to defining |
6017ef4
to
71126c1
Compare
Additionally, this fixes the following: * IDBEnvironment removed because it's officially obsolete and "although it may still work in some browsers, its use is discouraged since it could be removed at any time". * indexedDB now wrapped in js.UndefOr because it's not always available * indexedDB added to WorkerGlobalScope * caches return type changed from js.Any to js.UndefOr[CacheStorage] * caches added to Window * CacheStorage moved into experiment.cachestorage as it's available from Window too * Add missing methods to window and web-worker scopes: * crossOriginIsolated * isSecureContext * origin Ref: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope
commit c794a67 Author: exoego <[email protected]> Date: Thu Jun 25 12:21:53 2020 +0900 Add WindowOrWorkerGlobalScope
71126c1
to
db424e9
Compare
@japgolly is this binary compatible? I don't think this change is:
I think the rest would be okay though. So either undo just the |
@armanbilge Nah it's not. I'll update this soon (not today though) for compat. |
Ready to go @armanbilge ! |
This is a huge one so I'm just going to check changes with bincompat implications and assume you got the facade types right and/or they can be fixed compatibly in the future. |
Thanks @armanbilge ! 🚀 |
Thanks to you!! This was an important one :) Do you think we might get 1.2 out today? |
Ooooo do you want to? Are we ready? Anything else you want to add before we do? The only thing left on my list is to get #424 merged in for 1.2.0. I'm not sure if I'll get to it day though, feel free to take that one over if you want. Apart from the experimental question, I was also planning to just test |
@japgolly did you see my comment #424 (comment)? It's explained in the Scala.js docs (it's essentially equivalent to
I think so! The most important question for me is did we break anything, which I don't think so. If we forgot something or there are more nice-to-haves, theoretically we could do a 1.2.1 or 1.3 etc. I really really hope that getting a release out with all these merged PRs will encourage the community to become more engaged :) |
Supersedes #416.
Additionally, this fixes the following:
IDBEnvironment removed because it's officially obsolete and "although
it may still work in some browsers, its use is discouraged since it
could be removed at any time".
indexedDB now wrapped in js.UndefOr because it's not always available
indexedDB added to WorkerGlobalScope
caches return type changed from js.Any to js.UndefOr[CacheStorage]
caches added to Window
CacheStorage moved into experiment.cachestorage as it's available from
Window too
Add missing methods to window and web-worker scopes:
Ref: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope