Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add CanvasRenderingContext2D.imageSmoothingEnabled #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2021
Merged

Add CanvasRenderingContext2D.imageSmoothingEnabled #499

merged 2 commits into from
Aug 25, 2021

Conversation

JD557
Copy link
Contributor

@JD557 JD557 commented Aug 23, 2021

@armanbilge
Copy link
Member

@JD557 thanks for your contribution! Would you mind targeting this to the series/1.x branch and run prePR? Sorry for the confusion!

@armanbilge armanbilge changed the base branch from master to series/1.x August 23, 2021 18:10
@armanbilge
Copy link
Member

I think you'll have to rebase your branch and force-push, sorry :(

@JD557
Copy link
Contributor Author

JD557 commented Aug 23, 2021

Damn, you are fast... I was just going on gitter to ask "how do I run this sbt prePR thing? I don't see it anywhere?" 😛

I'll take care of that in a sec.

@armanbilge
Copy link
Member

armanbilge commented Aug 23, 2021 •
edited
Loading

Damn, you are fast...

Just trying to make up for lost time over here!! Btw, I changed the repository's default branch to series/1.x.

@JD557 JD557 force-pushed the imageSmoothingEnabled branch from 998f092 to e1b7a10 Compare August 23, 2021 18:24
@JD557 JD557 force-pushed the imageSmoothingEnabled branch from e1b7a10 to 3e78dea Compare August 23, 2021 18:31
@JD557
Copy link
Contributor Author

JD557 commented Aug 23, 2021

Rebased

armanbilge
armanbilge approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

@armanbilge armanbilge requested a review from japgolly August 23, 2021 18:35
@armanbilge armanbilge added this to the v1.2.0 milestone Aug 23, 2021
@japgolly japgolly merged commit f16c05b into scala-js:series/1.x Aug 25, 2021
@japgolly
Copy link
Contributor

Thanks for the PR @JD557 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@japgolly japgolly Awaiting requested review from japgolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JD557 @armanbilge @japgolly