Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix scala 3 warning. remove redundant final #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix scala 3 warning. remove redundant final #29

wants to merge 1 commit into from
+2 −2

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Sep 13, 2025 

[error] 122 |final object RunConfig {
[error]     |^^^^^
[error]     |Modifier final is redundant for this definition

[error] 238 |  private final case object Closing extends State
[error]     |          ^^^^^
[error]     |          Modifier final is redundant for this definition

@sjrd
Copy link
Member

sjrd commented Sep 13, 2025

For Scala 3 support, I would prefer a single PR with multiple commits: one for each kind of required change in the code, and finally one that adds building with Scala 3. Otherwise we can't really test whether the changes actually work.

@xuwei-k xuwei-k marked this pull request as draft September 13, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @sjrd