Add support for bloop server#400
Merged
Merged
Conversation
f5819be to
aa82ce8
Compare
aa82ce8 to
53de32c
Compare
Contributor
Author
|
CI error in 53de32c is spurious. |
Duhemm
requested changes
Mar 28, 2018
Collaborator
Duhemm
left a comment
There was a problem hiding this comment.
Maybe that we should also use bloop server to start the service in the homebrew formula?
| The server is installed by default in the same directory than the `bloop` | ||
| client, so `bloop server` will try to find the location of the server in the | ||
| same directory where `bloop` is installed. If this is not the case, run `bloop | ||
| ---server-location=/foo/my-blp-server server` instead. |
|
|
||
| The bloop server can serve responses of many concurrent clients. | ||
|
|
||
| #### Example |
Collaborator
There was a problem hiding this comment.
I think that we should get rid of this paragraph. It doesn't bring much, and the given example is not a runnable command (no project is specified).
Contributor
Author
Feedback addressed. |
Duhemm
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds improvements in nailgun that fix #320.