Scala 3 Fix evaluation involving captured variables#221
Merged
Conversation
Otherwise the expression denotations are unsound between the 2 phases
Time travel does not work after LambdaLift because LambdaLift creates new symbols. To resolve a term by reflection we need to know its name after BGen, and its capture. So we insert a phase after all the transform phases, called resolve-reflect-eval whose purpose is to resolve the temporary reflectEval calls into more precise methods. The EvaluationStrategy attachment conveys information about the term that must be evaluated.
To fix @main test, we need to store the expression symbol in a distinct phase group from the ExtractExpression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.