Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Add support for Scala 2.13.9#278

Merged
adpi2 merged 2 commits into
scalacenter:mainfrom
tgodzik:add-2.13.9
Sep 23, 2022
Merged

chore: Add support for Scala 2.13.9#278
adpi2 merged 2 commits into
scalacenter:mainfrom
tgodzik:add-2.13.9

Conversation

@tgodzik
Copy link
Copy Markdown
Collaborator

@tgodzik tgodzik commented Sep 22, 2022

No description provided.

@tgodzik tgodzik requested a review from adpi2 September 22, 2022 12:11
@tgodzik
Copy link
Copy Markdown
Collaborator Author

tgodzik commented Sep 22, 2022

@adpi2 Could you release expression evaluator for Scala 2.13.9? Maybe we could just configure a job that would run the release on a tag that we have in Metals?

@adpi2
Copy link
Copy Markdown
Member

adpi2 commented Sep 22, 2022

Yes I am going to release it and yes we should have a job :)

@tgodzik
Copy link
Copy Markdown
Collaborator Author

tgodzik commented Sep 22, 2022

Yes I am going to release it and yes we should have a job :)

Thanks! Locally running tests I am getting a lot of:

Exception in thread "Event Hub" io.reactivex.exceptions.OnErrorNotImplementedException: Empty encoded value for java.lang.String
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
        at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:74)
        at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:64)
        at io.reactivex.internal.operators.observable.ObservableFilter$FilterObserver.onNext(ObservableFilter.java:52)
        at io.reactivex.subjects.PublishSubject$PublishDisposable.onNext(PublishSubject.java:265)
        at io.reactivex.subjects.PublishSubject.onNext(PublishSubject.java:184)
        at com.microsoft.java.debug.core.EventHub.lambda$start$0(EventHub.java:82)
        at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.Exception: Empty encoded value for java.lang.String

Any idea why that is?

@adpi2
Copy link
Copy Markdown
Member

adpi2 commented Sep 22, 2022

Any idea why that is?

No idea. What's the full stack trace?

@tgodzik
Copy link
Copy Markdown
Collaborator Author

tgodzik commented Sep 22, 2022

It's something in microsoft debug server, but no idea why it would throw OnErrorNotImplementedException

Exception in thread "Event Hub" io.reactivex.exceptions.OnErrorNotImplementedException: Empty encoded value for java.lang.String
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
        at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
        at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:74)
        at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:64)
        at io.reactivex.internal.operators.observable.ObservableFilter$FilterObserver.onNext(ObservableFilter.java:52)
        at io.reactivex.subjects.PublishSubject$PublishDisposable.onNext(PublishSubject.java:265)
        at io.reactivex.subjects.PublishSubject.onNext(PublishSubject.java:184)
        at com.microsoft.java.debug.core.EventHub.lambda$start$0(EventHub.java:82)
        at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.Exception: Empty encoded value for java.lang.String
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.ifEmpty$lzycompute$1(Scala2StepFilter.scala:352)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.ifEmpty$1(Scala2StepFilter.scala:351)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.$anonfun$matchTypeSymbol$1(Scala2StepFilter.scala:358)
        at scala.runtime.java8.JFunction0$mcZ$sp.apply(JFunction0$mcZ$sp.java:23)
        at scala.Option.fold(Option.scala:251)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.matchTypeSymbol(Scala2StepFilter.scala:358)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.matchType(Scala2StepFilter.scala:218)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.matchReturnType$1(Scala2StepFilter.scala:153)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.matchSignature(Scala2StepFilter.scala:160)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.matchSymbol(Scala2StepFilter.scala:105)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.$anonfun$skipScalaMethod$3(Scala2StepFilter.scala:30)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.$anonfun$skipScalaMethod$3$adapted(Scala2StepFilter.scala:30)
        at scala.collection.TraversableLike.$anonfun$filterImpl$1(TraversableLike.scala:304)
        at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
        at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
        at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
        at scala.collection.TraversableLike.filterImpl(TraversableLike.scala:303)
        at scala.collection.TraversableLike.filterImpl$(TraversableLike.scala:297)
        at scala.collection.AbstractTraversable.filterImpl(Traversable.scala:108)
        at scala.collection.TraversableLike.filter(TraversableLike.scala:395)
        at scala.collection.TraversableLike.filter$(TraversableLike.scala:395)
        at scala.collection.AbstractTraversable.filter(Traversable.scala:108)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.skipScalaMethod(Scala2StepFilter.scala:30)
        at ch.epfl.scala.debugadapter.internal.stepfilter.ScalaStepFilter.skip(ScalaStepFilter.scala:26)
        at ch.epfl.scala.debugadapter.internal.stepfilter.ScalaStepFilter.skip$(ScalaStepFilter.scala:15)
        at ch.epfl.scala.debugadapter.internal.stepfilter.Scala2StepFilter.skip(Scala2StepFilter.scala:10)
        at ch.epfl.scala.debugadapter.internal.StepFilterProvider.$anonfun$skip$1(StepFilterProvider.scala:20)
        at ch.epfl.scala.debugadapter.internal.StepFilterProvider.$anonfun$skip$1$adapted(StepFilterProvider.scala:20)
        at scala.collection.LinearSeqOptimized.exists(LinearSeqOptimized.scala:95)
        at scala.collection.LinearSeqOptimized.exists$(LinearSeqOptimized.scala:92)
        at scala.collection.immutable.List.exists(List.scala:91)
        at ch.epfl.scala.debugadapter.internal.StepFilterProvider.skip(StepFilterProvider.scala:20)
        at com.microsoft.java.debug.core.adapter.handler.StepRequestHandler.shouldFilterLocation(StepRequestHandler.java:223)
        at com.microsoft.java.debug.core.adapter.handler.StepRequestHandler.handleDebugEvent(StepRequestHandler.java:170)
        at com.microsoft.java.debug.core.adapter.handler.StepRequestHandler.lambda$handle$1(StepRequestHandler.java:85)
        at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:60)
        ... 5 more

@adpi2
Copy link
Copy Markdown
Member

adpi2 commented Sep 23, 2022

That's because we throw an exception in the StepFilterProvider and the java debug server does not know how to consume this exception.

@adpi2
Copy link
Copy Markdown
Member

adpi2 commented Sep 23, 2022

Looking at Caused by: java.lang.Exception: Empty encoded value for java.lang.String it seems that the debugger cannot load the JDK. What is your Java version?

@adpi2 adpi2 merged commit e281751 into scalacenter:main Sep 23, 2022
@tgodzik tgodzik deleted the add-2.13.9 branch September 23, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants