You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update is to add trained_slice_id to the model object. So that when we create a model (with NUCLEUS_CLIENT.create_model) we are able to associate a trained_slice_id with it.
I did not change the repr response, since it causes issues with the test comparison. Let me know if we want to simplify the repr and modify the test or leave as is.
Talked with Ryan on Slack, I think we'll sync up with @levinwil tomorrow to scope out exactly what he needs for his work. We can always backfill trained_slice_id in the PSQL database at a later date, so I don't think it's really necessary to push through ASAP
Talked with Ryan on Slack, I think we'll sync up with @levinwil tomorrow to scope out exactly what he needs for his work. We can always backfill trained_slice_id in the PSQL database at a later date, so I don't think it's really necessary to push through ASAP
feel free to loop me in, happy to learn more about the context here
@scaleapi/nucleus-eng If the PR looks good to y'all, would someone be able to merge it please. @schumry I bumped the version and added a CHANGELOG - you need to bump the version for the new version to be deployed to PyPI. I'll merge this once tests pass.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update is to add
trained_slice_idto the model object. So that when we create a model (withNUCLEUS_CLIENT.create_model) we are able to associate atrained_slice_idwith it.I did not change the repr response, since it causes issues with the test comparison. Let me know if we want to simplify the repr and modify the test or leave as is.
Associated scaleapi PR: https://github.com/scaleapi/scaleapi/pull/74083
Previous PR: #419