Move Python files that are *scripts* into /scripts/ and adjust.#4819
Conversation
8e27485 to
20194bd
Compare
| } | ||
|
|
||
| TYPES: #eg-314 DefinedTerm, DefinedTermSet, inDefinedTermSet | ||
| TYPES: #eg-0315 DefinedTerm, DefinedTermSet, inDefinedTermSet |
There was a problem hiding this comment.
the 0 padding I wouldn't be so surprised by - do we know where the +1 increment is coming fro?
There was a problem hiding this comment.
it does count from a number, based on the number of valid types we have. As I let Gemini verify the examples it could be that these were outdated anyway. and there is no test to assert that the examples a) result in this, and b) actually work.
| <div> | ||
| <div itemscope itemtype="https://schema.org/DefinedTermSet"> | ||
| <meta itemprop="additionalType" content="https://schema.org/Book"> | ||
| <link itemprop="additionalType" href="https://schema.org/Book"> |
There was a problem hiding this comment.
Does the change which cause this diff impact the site generation also?
There was a problem hiding this comment.
This is the same reason, the examples code has been verified.
|
|
||
| # Setup testharness state BEFORE importing sdo libraries | ||
| setInTestHarness(True) | ||
| # Ensure that the google.appengine.* packages are available |
There was a problem hiding this comment.
this is a test? can this be in main?
| from testharness import * | ||
|
|
||
| # Setup testharness state BEFORE importing sdo libraries | ||
| setInTestHarness(True) |
There was a problem hiding this comment.
same here, can this be in main?
Scripts (Python files expected to be called on the command line) are moved into the script dir. We also adjust all other Python files, documentation, and remove all the import path handling from non-script files. We further assume the directory from which these are run is the root of the project (i.e. `schemaorg`) and therefore loading other Python files can be greatly simplified.
20194bd to
fc98c5c
Compare
Scripts (Python files expected to be called on the command line) are moved into the script dir.
schemaorg) and therefore loading other Python files can be greatly simplified;