core(node) Move to setting exitCode vs calling exit(code)#1
Closed
EugeneHlushko wants to merge 1 commit intoschleyfox:masterfrom
Closed
core(node) Move to setting exitCode vs calling exit(code)#1EugeneHlushko wants to merge 1 commit intoschleyfox:masterfrom
EugeneHlushko wants to merge 1 commit intoschleyfox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an issue with
process.exit(code)at webpack in the past where Node.js did not exit itself after theprocess.exit(1)was called.https://nodejs.org/dist/latest-v9.x/docs/api/process.html#process_process_exit_code
For details you can see old PR with issue.
webpack/webpack#6193