feat: Add 'name-tests-test' to pre-commit hooks #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the 'name-tests-test' pre-commit hooks which verifies that test files under tests/ conform to pytest naming conventions. - Use the '--pytest-test-first' option to match the 'test_.*\.py' naming convention.
e3a0f04 to
ea30722
Compare
|
Could you also add a check for this being used? No need to check for the arg setting, but adding this as a check would be ideal. |
|
Oh, I didn't add individual checks for hooks (yet). Nevermind. |
henryiii
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by scikit-hep/scikit-hep.github.io#227 and complimentary to PR scikit-hep/scikit-hep.github.io#231.
tests/conform topytestnaming conventions.--pytest-test-firstoption to match thetest_.*\.pynaming convention.