Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add pybind11 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
matthewfeickert opened this issue May 16, 2025 · 20 comments
Closed
7 tasks done

Add pybind11 #134

matthewfeickert opened this issue May 16, 2025 · 20 comments
Assignees

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented May 16, 2025

Motviated by #124 (comment):

@henryiii Please have a member of the pybind11 team complete the missing items from the checklist to get started.

image

If you'd also like to use the scientific/upload-nightly-action GitHub Action please check out the action repo's README. If you need to collect wheels from different CI jobs, consider creating a new GitHub Actions workflow with logic similar to matplotlib's or Awkward's.

If you have any questions please just ask here!

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 16, 2025

Also thank you @bsipocz for adding the new project label! I'll try to remember to do that in the future.

@bsipocz
Copy link
Member

bsipocz commented May 16, 2025

No worries, I'm just a labelling maniac at times :)

@henryiii
Copy link

Is it okay that it will upload both pybind11 and pybind11_global?

@matthewfeickert
Copy link
Member Author

@henryiii, yes, that's fine but I need to add both packages to the team to have them be able to upload. I just need a pybind11_global wheel to seed it.

@henryiii
Copy link

Can you upload an older released one?

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 20, 2025

Can you upload an older released one?

Yup. I will do so now.

@matthewfeickert
Copy link
Member Author

@henryiii done now (https://anaconda.org/scientific-python-nightly-wheels/pybind11_global). You can start uploading wheels for both.

@henryiii
Copy link

Error:  ('User "<User: _login=henryiii>" has not enough permissions to create "<User: _login=scientific-python-nightly-wheels>/pybind11-global" package', 401)

Is this -/_ sensitive? Conda is, but wheelhouses are not supposed to be?

@matthewfeickert
Copy link
Member Author

@henryiii I'm currently on a flight so hard for me to check, but is the name of the wheel that you're uploading different from what you had on PyPI? I see that you're uploading scikit-build-core fine (https://anaconda.org/scientific-python-nightly-wheels/scikit_build_core/files) so I'm not sure why there should be an issue here with pybind11-global. Can you check what's different between the two project wheels?

@henryiii
Copy link

Are there no SDists there? Wheels always have _ in the name, so it can't be that if it's wheel only. Maybe the action doesn't know about uploading to two projects?

@henryiii
Copy link

My guess is it's reading the name from the metadata (which is pybind11-global) (the wheel name is pybind11_global*, and then the project name url is incorrect, so it thinks I can't upload there.

@henryiii
Copy link

I'm going to try renaming it to pybind11_global.

@henryiii
Copy link

Actually, how hard would it be to remove and recreate the project with the -?

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 21, 2025

Actually, how hard would it be to remove and recreate the project with the -?

Trivial to do, but I need my laptop to do that as the project is created from the wheel that is uploaded originally and I only have my phone for the next 4 hours. So I can do that when I land and you can try tomorrow?

This is very strange to me though:

+ anaconda --token *** upload --force --user scientific-python-nightly-wheels --label main dist/pybind11-3.0.0rc1-py3-none-any.whl dist/pybind11_global-3.0.0rc1-py3-none-any.whl
Uploading wheels to anaconda.org...
Using Anaconda API: https://api.anaconda.org
Using "scientific-python-nightly-wheels" as upload username
Processing "dist/pybind11-3.0.0rc1-py3-none-any.whl"
Detecting file type...
File type is "Standard Python"
Extracting standard python attributes for upload
Warning:  Distribution "pybind11-3.0.0rc1-py3-none-any.whl" already exists. Removing.
Creating package "pybind11"
Creating release "3.0.0rc1"
Uploading file "scientific-python-nightly-wheels/pybind11/3.0.0rc1/pybind11-3.0.0rc1-py3-none-any.whl"

  0%|          | 0.00/281k [00:00<?, ?B/s]
 34%|███▍      | 96.0k/281k [00:00<00:00, 854kB/s]
287kB [00:00, 1.20MB/s]                           
Upload complete

Processing "dist/pybind11_global-3.0.0rc1-py3-none-any.whl"
Detecting file type...
File type is "Standard Python"
Extracting standard python attributes for upload
Creating package "pybind11-global"
standard python located at:
  https://anaconda.org/scientific-python-nightly-wheels/pybind11

Error:  ('User "<User: _login=henryiii>" has not enough permissions to create "<User: _login=scientific-python-nightly-wheels>/pybind11-global" package', 401)
Error: Process completed with exit code 1.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 21, 2025

@henryiii I've created https://anaconda.org/scientific-python-nightly-wheels/pybind11-global by uploading the nightly wheel you generated in https://github.com/pybind/pybind11/actions/runs/15152544486. I've also deleted https://anaconda.org/scientific-python-nightly-wheels/pybind11_global by removing all the wheels from it. So the pybind11 group which you have admin permissions on now has the following packages under it:

Can you retrigger a run of the pybind11 nightlies.yml GitHub Actions workflow to see if you can upload now?

@henryiii
Copy link

https://github.com/pybind/pybind11/actions/runs/15154528551

Works!

@matthewfeickert
Copy link
Member Author

Fantastic! Thanks very much for suggesting pybind11 @henryiii — it is great to have these tools providing nightly wheels.

I'm going to close this out now as we've got working uploads, but feel free to ping if you have any questions in the future. 👍

@henryiii
Copy link

What about boost-histogram (and maybe hist & uhi)?

@matthewfeickert
Copy link
Member Author

What about boost-histogram (and maybe hist & uhi)?

@henryiii If you think there is value for testing the Scikit-HEP stack on nighlies for these then I think that's probably fine as they're all part of the domain stack. I don't think that any existing projects have dependencies on them, but if Scikit-HEP people are in favor (and as one of them I would say yes) then can you please open up an issue for this? (Given that they're all histogram related you can just do it in one rather than 3).

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 23, 2025

but if Scikit-HEP people are in favor (and as one of them I would say yes) then can you please open up an issue for this?

@andrzejnovak indicated interest, so 3 people counting myself seems to be good enough for Issue #135. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants