Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Use micromamba for speed and set anaconda-client version #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2023
Merged

ENH: Use micromamba for speed and set anaconda-client version #23

merged 3 commits into from
Jul 18, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jul 15, 2023 •
edited
Loading

High level summary:

  • Use micromamba for speed.
  • Configure Docker image environment for shell environment stability.
  • Explicitly set anaconda-client version for reproducibility and security. (This should ideally be a lock file but one thing at a time).

@matthewfeickert matthewfeickert self-assigned this Jul 15, 2023
This was referenced Jul 15, 2023
Closed
Closed
@matthewfeickert
ENH: Use micromamba
c8f02e7 
* Use mambaorg/micromamba:1.4.9-bullseye-slim as base image.
* Set container shell to Bash explicitly.
* Use C.UTF-8 to avoid issues with unicode.
@matthewfeickert
MNT: Set anaconda-client version for security stability
6b9927a 
* Explicitly set the anaconda-client version to know what version is
  being used for upload.
* Use anaconda-client v1.12.0 to aovid CONDA_ROOT micromamba config error.
   - c.f. anaconda/anaconda-client#636
@matthewfeickert
MNT: Use full CLI API options and quote guard shell variables
86fdbc4
@matthewfeickert matthewfeickert force-pushed the feat/use-micromamba-for-speed branch from 7cf89ad to 86fdbc4 Compare July 18, 2023 17:10
@matthewfeickert matthewfeickert added this to the 0.2.0 milestone Jul 18, 2023
matthewfeickert
matthewfeickert commented Jul 18, 2023
View reviewed changes
entrypoint.sh
echo "ANACONDA_TOKEN is empty , exiting..."
exit -1
fi

export ANACONDA_CLIENT_VERSION="1.12.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using v1.12.0 fixes the problems in anaconda/anaconda-client#636.

@matthewfeickert
Copy link
Member Author

I'm going to merge this as we have multiple people approving (thanks for fast reviews!). Comments from others are always welcome.

Anyone object to making a v0.2.0 release from this?

@matthewfeickert matthewfeickert merged commit c5542a0 into scientific-python:main Jul 18, 2023
@matthewfeickert matthewfeickert deleted the feat/use-micromamba-for-speed branch July 18, 2023 19:54
@matthewfeickert matthewfeickert mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanv stefanv stefanv approved these changes

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@Carreau Carreau Awaiting requested review from Carreau

@betatim betatim Awaiting requested review from betatim

@bsipocz bsipocz Awaiting requested review from bsipocz

Assignees

@matthewfeickert matthewfeickert

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewfeickert @stefanv @jarrodmillman