Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: experiment.UseCustomOrdering()#167

Merged
JoshHiles merged 5 commits intoscientistproject:masterfrom
JoshHiles:feature/user-defined-ordering
Nov 20, 2025
Merged

feat: experiment.UseCustomOrdering()#167
JoshHiles merged 5 commits intoscientistproject:masterfrom
JoshHiles:feature/user-defined-ordering

Conversation

@JoshHiles
Copy link
Contributor

Addresses some of the concerns raised in #166 & resolves #159

A new method experiment.UseCustomOrdering() which takes a delegate to run custom behaviour ordering.

@JoshHiles
Copy link
Contributor Author

Should we provide some extra docs on the async way of doing this? Potentially point them to the tests?
I also thought about whether we should include a weight variable or perhaps tags but that can be an extra feature in the future i think

Copy link
Contributor

@M-Zuber M-Zuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
TA!

@M-Zuber
Copy link
Contributor

M-Zuber commented Nov 19, 2025

Should we provide some extra docs on the async way of doing this? Potentially point them to the tests?
I may have missed something, but I don't see that there is a major difference between using async vs sync, so maybe that is an argument for more documentation actually 😄

I also thought about whether we should include a weight variable or perhaps tags but that can be an extra feature in the future i think
Def a candidate for something we can support, but also def for the future

@M-Zuber M-Zuber self-requested a review November 19, 2025 17:19
@M-Zuber
Copy link
Contributor

M-Zuber commented Nov 19, 2025

LGTM

@JoshHiles JoshHiles merged commit f43c611 into scientistproject:master Nov 20, 2025
5 checks passed
@JoshHiles JoshHiles deleted the feature/user-defined-ordering branch November 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support a non-randomized execution order

2 participants