Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Improve the RANSAC gallery example #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2018
Merged

DOC: Improve the RANSAC gallery example #3554

merged 3 commits into from
Dec 9, 2018

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Nov 17, 2018

Description

It was reported to me that this example was misleading.

I added part of the function docstring + merged two examples as the 3D is just a small adaptation of the 2D case.

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@sciunto sciunto added the 📄 type: Documentation Updates, fixes and additions to documentation label Nov 17, 2018
@pep8speaks
Copy link

pep8speaks commented Nov 17, 2018 •
edited
Loading

Hello @sciunto! Thanks for updating the PR.

Line 86:1: E402 module level import not at top of file
Line 87:1: E402 module level import not at top of file
Line 88:1: E402 module level import not at top of file
Line 89:1: E402 module level import not at top of file
Line 107:20: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 113:80: E501 line too long (80 > 79 characters)

Comment last updated on December 09, 2018 at 17:41 Hours UTC

jni
jni reviewed Nov 20, 2018
View reviewed changes
jni
jni reviewed Nov 20, 2018
View reviewed changes
jni
jni approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just made two very minor suggestions.

emmanuelle
emmanuelle reviewed Nov 24, 2018
View reviewed changes
doc/examples/transform/plot_ransac.py Outdated
from a subset of inliers from the complete data set. Each iteration
performs the following tasks:

1. Select ``min_samples`` random samples from the original data and can check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can check --> check?

@emmanuelle
Copy link
Member

@sciunto it doesn't look like you commited the changes suggested by @jni, or did I miss something? I also noted something which is a typo I think, otherwise LGTM.

@sciunto
Copy link
Member Author

sciunto commented Nov 25, 2018

All is fixed! thanks

@emmanuelle
Copy link
Member

Merging, thanks.

@sciunto
Copy link
Member Author

sciunto commented Dec 9, 2018

@emmanuelle you didn't press the green button, did you? :)

soupault
soupault reviewed Dec 9, 2018
View reviewed changes
@soupault soupault added this to the 0.15 milestone Dec 9, 2018
@emmanuelle
Copy link
Member

@sciunto yes sorry I must have been distracted. Can you just take a look at which suggestions of @soupault you want to incorporate, then ping me and I'll merge for real :-).

@sciunto
Improve phrasing
a2a537f 
Co-Authored-By: sciunto <[email protected]>
@sciunto
Copy link
Member Author

sciunto commented Dec 9, 2018

Great suggestions. Nice collaborative work. I merged them all @emmanuelle

@soupault soupault changed the title DOC: enhance presentation of RANSAC linear fits DOC: Improve the RANSAC gallery example Dec 9, 2018
@soupault soupault merged commit 6059644 into scikit-image:master Dec 9, 2018
@soupault
Copy link
Member

soupault commented Dec 9, 2018

Thanks Francois!

@sciunto sciunto deleted the doc_ransac branch December 9, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle left review comments

@soupault soupault soupault left review comments

@jni jni jni approved these changes

Assignees
No one assigned
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
5 participants
@sciunto @pep8speaks @emmanuelle @soupault @jni